diff options
author | Konrad Rzeszutek Wilk <[email protected]> | 2015-11-02 18:13:27 -0500 |
---|---|---|
committer | Konrad Rzeszutek Wilk <[email protected]> | 2015-12-18 10:48:39 -0500 |
commit | 408fb0e5aa7fda0059db282ff58c3b2a4278baa0 (patch) | |
tree | 777fad3ba2e341d7d7ac6d939bb94e99ba621920 /net/lapb/lapb_in.c | |
parent | 7cfb905b9638982862f0331b36ccaaca5d383b49 (diff) |
xen/pciback: Don't allow MSI-X ops if PCI_COMMAND_MEMORY is not set.
commit f598282f51 ("PCI: Fix the NIU MSI-X problem in a better way")
teaches us that dealing with MSI-X can be troublesome.
Further checks in the MSI-X architecture shows that if the
PCI_COMMAND_MEMORY bit is turned of in the PCI_COMMAND we
may not be able to access the BAR (since they are memory regions).
Since the MSI-X tables are located in there.. that can lead
to us causing PCIe errors. Inhibit us performing any
operation on the MSI-X unless the MEMORY bit is set.
Note that Xen hypervisor with:
"x86/MSI-X: access MSI-X table only after having enabled MSI-X"
will return:
xen_pciback: 0000:0a:00.1: error -6 enabling MSI-X for guest 3!
When the generic MSI code tries to setup the PIRQ without
MEMORY bit set. Which means with later versions of Xen
(4.6) this patch is not neccessary.
This is part of XSA-157
CC: [email protected]
Reviewed-by: Jan Beulich <[email protected]>
Signed-off-by: Konrad Rzeszutek Wilk <[email protected]>
Diffstat (limited to 'net/lapb/lapb_in.c')
0 files changed, 0 insertions, 0 deletions