diff options
author | Yasuaki Ishimatsu <[email protected]> | 2013-04-29 15:08:39 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2013-04-29 15:54:38 -0700 |
commit | 7a6f93b0a873ad24631088c349e9d1ca3d4cf852 (patch) | |
tree | d824fc12bcd0c59fcee9cfc89f74f218bb51d594 /net/lapb/lapb_iface.c | |
parent | 40f4b1ead0e7a31bd1acf9b683f9ddcf52b0dfe4 (diff) |
firmware, memmap: fix firmware_map_entry leak
When hot removing memory, a firmware_map_entry which has memory range of
the memory is released by release_firmware_map_entry(). If the entry is
allocated by bootmem, release_firmware_map_entry() adds the entry to
map_entires_bootmem list when firmware_map_find_entry() finds the entry
from map_entries list. But firmware_map_find_entry never find the entry
sicne map_entires list does not have the entry. So the entry just
leaks.
Here are steps of leaking firmware_map_entry:
firmware_map_remove()
-> firmware_map_find_entry()
Find released entry from map_entries list
-> firmware_map_remove_entry()
Delete the entry from map_entries list
-> remove_sysfs_fw_map_entry()
...
-> release_firmware_map_entry()
-> firmware_map_find_entry()
Find the entry from map_entries list but the entry has been
deleted from map_entries list. So the entry is not added
to map_entries_bootmem. Thus the entry leaks
release_firmware_map_entry() should not call firmware_map_find_entry()
since releaed entry has been deleted from map_entries list. So the
patch delete firmware_map_find_entry() from releae_firmware_map_entry()
Signed-off-by: Yasuaki Ishimatsu <[email protected]>
Reviewed-by: Wanpeng Li <[email protected]>
Reviewed-by: Tang Chen <[email protected]>
Acked-by: Toshi Kani <[email protected]>
Cc: Wen Congyang <[email protected]>
Cc: Greg KH <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'net/lapb/lapb_iface.c')
0 files changed, 0 insertions, 0 deletions