diff options
author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-11-27 22:32:31 -0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-11-30 13:33:34 -0800 |
commit | a293974590cfdc2d59c559a54d62a5ecb648104b (patch) | |
tree | db2bac40463214bd580b4138924f0e082309383c /net/core/gen_stats.c | |
parent | 420d031822737ef570df6834c0eae26f33988f20 (diff) |
rtnetlink: avoid frame size warning in rtnl_newlink()
Standard kernel compilation produces the following warning:
net/core/rtnetlink.c: In function ‘rtnl_newlink’:
net/core/rtnetlink.c:3232:1: warning: the frame size of 1288 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
This should not really be an issue, as rtnl_newlink() stack is
generally quite shallow.
Fix the warning by allocating attributes with kmalloc() in a wrapper
and passing it down to rtnl_newlink(), avoiding complexities on error
paths.
Alternatively we could kmalloc() some structure within rtnl_newlink(),
slave attributes look like a good candidate. In practice it adds to
already rather high complexity and length of the function.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/gen_stats.c')
0 files changed, 0 insertions, 0 deletions