diff options
author | Vladimir Oltean <vladimir.oltean@nxp.com> | 2022-01-05 15:18:11 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2022-01-05 15:04:50 +0000 |
commit | ff91e1b68490b97c18c649b769618815eb945f11 (patch) | |
tree | 36cff3b5559f227b89192bdfa9f766467639d58f /net/bridge | |
parent | d43e4271747ace01a27a49a97a397cb4219f6487 (diff) |
net: dsa: fix incorrect function pointer check for MRP ring roles
The cross-chip notifier boilerplate code meant to check the presence of
ds->ops->port_mrp_add_ring_role before calling it, but checked
ds->ops->port_mrp_add instead, before calling
ds->ops->port_mrp_add_ring_role.
Therefore, a driver which implements one operation but not the other
would trigger a NULL pointer dereference.
There isn't any such driver in DSA yet, so there is no reason to
backport the change. Issue found through code inspection.
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Fixes: c595c4330da0 ("net: dsa: add MRP support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions