diff options
author | Valentin Schneider <[email protected]> | 2022-01-20 16:25:19 +0000 |
---|---|---|
committer | Peter Zijlstra <[email protected]> | 2022-03-01 16:18:39 +0100 |
commit | fa2c3254d7cfff5f7a916ab928a562d1165f17bb (patch) | |
tree | 678cc10a62564212f526fc4a65ea345fde95794e /lib | |
parent | 49bef33e4b87b743495627a529029156c6e09530 (diff) |
sched/tracing: Don't re-read p->state when emitting sched_switch event
As of commit
c6e7bd7afaeb ("sched/core: Optimize ttwu() spinning on p->on_cpu")
the following sequence becomes possible:
p->__state = TASK_INTERRUPTIBLE;
__schedule()
deactivate_task(p);
ttwu()
READ !p->on_rq
p->__state=TASK_WAKING
trace_sched_switch()
__trace_sched_switch_state()
task_state_index()
return 0;
TASK_WAKING isn't in TASK_REPORT, so the task appears as TASK_RUNNING in
the trace event.
Prevent this by pushing the value read from __schedule() down the trace
event.
Reported-by: Abhijeet Dharmapurikar <[email protected]>
Signed-off-by: Valentin Schneider <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Steven Rostedt (Google) <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions