aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorMika Westerberg <[email protected]>2022-10-28 09:27:50 +0300
committerWim Van Sebroeck <[email protected]>2022-11-19 15:30:41 +0100
commitef9b7bf52c2f47f0a9bf988543c577b92c92d15e (patch)
tree6988f086c4c34d569f55af8920bffa8ba007daf9 /lib
parent47c008050aec3e9a13af29dd74cd8b4c112bc07b (diff)
watchdog: iTCO_wdt: Set NO_REBOOT if the watchdog is not already running
Daniel reported that the commit 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe") makes QEMU implementation of the iTCO watchdog not to trigger reboot anymore when NO_REBOOT flag is initially cleared using this option (in QEMU command line): -global ICH9-LPC.noreboot=false The problem with the commit is that it left the unconditional setting of NO_REBOOT that is not cleared anymore when the kernel keeps pinging the watchdog (as opposed to the previous code that called iTCO_wdt_stop() that cleared it). Fix this so that we only set NO_REBOOT if the watchdog was not initially running. Fixes: 1ae3e78c0820 ("watchdog: iTCO_wdt: No need to stop the timer in probe") Reported-by: Daniel P. BerrangĂ© <[email protected]> Signed-off-by: Mika Westerberg <[email protected]> Tested-by: Daniel P. BerrangĂ© <[email protected]> Reviewed-by: Daniel P. BerrangĂ© <[email protected]> Reviewed-by: Guenter Roeck <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Guenter Roeck <[email protected]> Signed-off-by: Wim Van Sebroeck <[email protected]>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions