diff options
| author | Andrew Halaney <ahalaney@redhat.com> | 2024-08-29 15:48:44 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-09-02 13:44:09 +0100 |
| commit | 55ddb6c5a3aef8d8658fe31b1ddda007693ae797 (patch) | |
| tree | 2bc9cfa9c83b8f75a5882a48fd5ec9a9d3955d99 /lib | |
| parent | 221f9cce949ac8042f65b71ed1fde13b99073256 (diff) | |
net: stmmac: drop the ethtool begin() callback
This callback doesn't seem to serve much purpose, and prevents things
like:
- systemd.link files from disabling autonegotiation
- carrier detection in NetworkManager
- any ethtool setting
prior to userspace bringing the link up.
The only fear I can think of is accessing unclocked resources due to
pm_runtime, but ethtool ioctls handle that as of commit
f32a21376573 ("ethtool: runtime-resume netdev parent before ethtool ioctl ops")
Reviewed-by: Dmitry Dolenko <d.dolenko@metrotek.ru>
Tested-by: Dmitry Dolenko <d.dolenko@metrotek.ru>
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions