aboutsummaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorJarkko Sakkinen <[email protected]>2015-09-29 00:32:19 +0300
committerPeter Huewe <[email protected]>2015-10-19 01:01:14 +0200
commit399235dc6e95400a1322a9999e92073bc572f0c8 (patch)
treeda5b36115c8e3a7681e649d7ec4791dc6ce503a0 /lib
parent149789ce9d472e6b4fd99336e779ab843754a96c (diff)
tpm, tpm_tis: fix tpm_tis ACPI detection issue with TPM 2.0
Both for FIFO and CRB interface TCG has decided to use the same HID MSFT0101. They can be differentiated by looking at the start method from TPM2 ACPI table. This patches makes necessary fixes to tpm_tis and tpm_crb modules in order to correctly detect, which module should be used. For MSFT0101 we must use struct acpi_driver because struct pnp_driver has a 7 character limitation. It turned out that the root cause in b371616b8 was not correct for https://bugzilla.kernel.org/show_bug.cgi?id=98181. v2: * One fixup was missing from v1: is_tpm2_fifo -> is_fifo v3: * Use pnp_driver for existing HIDs and acpi_driver only for MSFT0101 in order ensure backwards compatibility. v4: * Check for FIFO before doing *anything* in crb_acpi_add(). * There was return immediately after acpi_bus_unregister_driver() in cleanup_tis(). This caused pnp_unregister_driver() not to be called. Cc: [email protected] Reported-by: Michael Saunders <[email protected]> Reported-by: Michael Marley <[email protected]> Reported-by: Jethro Beekman <[email protected]> Reported-by: Matthew Garrett <[email protected]> Signed-off-by: Jarkko Sakkinen <[email protected]> Tested-by: Michael Marley <[email protected]> Tested-by: Mimi Zohar <[email protected]> (on TPM 1.2) Reviewed-by: Peter Huewe <[email protected]> Signed-off-by: Peter Huewe <[email protected]>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions