diff options
author | Xiyu Yang <[email protected]> | 2020-04-25 20:48:35 +0800 |
---|---|---|
committer | Mark Brown <[email protected]> | 2020-04-28 13:33:56 +0100 |
commit | a697ae6ea56e23397341b027098c1b11d9ab13da (patch) | |
tree | c4c6a92b882419d71983a436f7883337a1e1d3f6 /lib/test_overflow.c | |
parent | 1fecbb71fe0e46b886f84e3b6decca6643c3af6d (diff) |
ASoC: davinci-mcasp: Fix dma_chan refcnt leak when getting dma type
davinci_mcasp_get_dma_type() invokes dma_request_chan(), which returns a
reference of the specified dma_chan object to "chan" with increased
refcnt.
When davinci_mcasp_get_dma_type() returns, local variable "chan" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
davinci_mcasp_get_dma_type(). When chan device is NULL, the function
forgets to decrease the refcnt increased by dma_request_chan(), causing
a refcnt leak.
Fix this issue by calling dma_release_channel() when chan device is
NULL.
Signed-off-by: Xiyu Yang <[email protected]>
Signed-off-by: Xin Tan <[email protected]>
Acked-by: Peter Ujfalusi <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions