diff options
| author | Miri Korenblit <[email protected]> | 2022-01-28 14:30:51 +0200 |
|---|---|---|
| committer | Kalle Valo <[email protected]> | 2022-02-03 10:24:47 +0200 |
| commit | 973f02c932b0be41a26bb9bdf38b7b92721611d2 (patch) | |
| tree | 35752dd882d35159b00821fca4c717a43c6ba77c /lib/test_overflow.c | |
| parent | be8287c9b8326d767429c8371bbc78b33f6efe13 (diff) | |
iwlwifi: fix iwl_legacy_rate_to_fw_idx
There are a couple of bugs in this function:
1. It is declared as a non-static function, even though
it's only used in one file.
2. Its return value should be of type u32 but it returns
(in some cases) -1.
Fix them by making this function static and returning an
error value of type unsigned.
In addition, we're assigning the return value of this function
as the legacy rate even if the function returned an error value.
Fix this by assigning the lowest rate in this case.
Signed-off-by: Miri Korenblit <[email protected]>
Reported-by: Ye Guojin <[email protected]>
Reported-by: Zeal Robot <[email protected]>
Fixes: 9998f81e4ba5 ("iwlwifi: mvm: convert old rate & flags to the new format.")
Signed-off-by: Luca Coelho <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://lore.kernel.org/r/iwlwifi.20220128142706.5612eeb9d6d0.I992e10d93fc22919b2bc42daad087ee1b5d6f014@changeid
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions