aboutsummaryrefslogtreecommitdiff
path: root/lib/test_overflow.c
diff options
context:
space:
mode:
authorNeilBrown <[email protected]>2019-08-13 15:37:44 -0700
committerLinus Torvalds <[email protected]>2019-08-13 16:06:52 -0700
commit6a2aeab59e97101b4001bac84388fc49a992f87e (patch)
treef2a3b5188de3354b5f53d1b605270407d6b6fb82 /lib/test_overflow.c
parentec9f02384f6053f2a5417e82b65078edc5364a8d (diff)
seq_file: fix problem when seeking mid-record
If you use lseek or similar (e.g. pread) to access a location in a seq_file file that is within a record, rather than at a record boundary, then the first read will return the remainder of the record, and the second read will return the whole of that same record (instead of the next record). When seeking to a record boundary, the next record is correctly returned. This bug was introduced by a recent patch (identified below). Before that patch, seq_read() would increment m->index when the last of the buffer was returned (m->count == 0). After that patch, we rely on ->next to increment m->index after filling the buffer - but there was one place where that didn't happen. Link: https://lkml.kernel.org/lkml/[email protected]/ Fixes: 1f4aace60b0e ("fs/seq_file.c: simplify seq_file iteration code and interface") Signed-off-by: NeilBrown <[email protected]> Reported-by: Sergei Turchanov <[email protected]> Tested-by: Sergei Turchanov <[email protected]> Cc: Alexander Viro <[email protected]> Cc: Markus Elfring <[email protected]> Cc: <[email protected]> [4.19+] Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions