diff options
author | Karsten Graul <[email protected]> | 2021-11-24 13:32:37 +0100 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2021-11-24 19:02:21 -0800 |
commit | 587acad41f1bc48e16f42bb2aca63bf323380be8 (patch) | |
tree | f2cdb384949c5d332d0a57aa0b0bdb7c48ffd48f /lib/test_overflow.c | |
parent | 06e5ba71750861acf65fb1b0cfb8f974159100af (diff) |
net/smc: Fix NULL pointer dereferencing in smc_vlan_by_tcpsk()
Coverity reports a possible NULL dereferencing problem:
in smc_vlan_by_tcpsk():
6. returned_null: netdev_lower_get_next returns NULL (checked 29 out of 30 times).
7. var_assigned: Assigning: ndev = NULL return value from netdev_lower_get_next.
1623 ndev = (struct net_device *)netdev_lower_get_next(ndev, &lower);
CID 1468509 (#1 of 1): Dereference null return value (NULL_RETURNS)
8. dereference: Dereferencing a pointer that might be NULL ndev when calling is_vlan_dev.
1624 if (is_vlan_dev(ndev)) {
Remove the manual implementation and use netdev_walk_all_lower_dev() to
iterate over the lower devices. While on it remove an obsolete function
parameter comment.
Fixes: cb9d43f67754 ("net/smc: determine vlan_id of stacked net_device")
Suggested-by: Julian Wiedmann <[email protected]>
Signed-off-by: Karsten Graul <[email protected]>
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'lib/test_overflow.c')
0 files changed, 0 insertions, 0 deletions