diff options
| author | Bjorn Helgaas <[email protected]> | 2023-11-21 12:36:41 -0600 |
|---|---|---|
| committer | Bjorn Helgaas <[email protected]> | 2023-12-05 10:56:56 -0600 |
| commit | f284dff47b6d00efe1f774d25e9d74874e78c600 (patch) | |
| tree | 81b37eb0e71154d18bfbb13f95ce8141996dc3b8 /lib/test_fortify/write_overflow-strncpy-src.c | |
| parent | d26e7fc3d907db19f7e25126476cb416f0527592 (diff) | |
x86/pci: Comment pci_mmconfig_insert() obscure MCFG dependency
In pci_mmconfig_insert(), there's no reference to "addr" between locking
pci_mmcfg_lock and testing "addr", so it *looks* like we should move the
test before the lock.
But 07f9b61c3915 ("x86/PCI: MMCONFIG: Check earlier for MMCONFIG region at
address zero") did that, which broke things by returning -EINVAL when
"addr" is zero instead of -EEXIST.
So 07f9b61c3915 was reverted by 67d470e0e171 ("Revert "x86/PCI: MMCONFIG:
Check earlier for MMCONFIG region at address zero"").
Add a comment about this issue to prevent it from happening again.
Link: https://lore.kernel.org/r/[email protected]
Tested-by: Tomasz Pala <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strncpy-src.c')
0 files changed, 0 insertions, 0 deletions