diff options
| author | NeilBrown <[email protected]> | 2024-06-25 09:04:57 +1000 |
|---|---|---|
| committer | Chuck Lever <[email protected]> | 2024-06-25 10:18:05 -0400 |
| commit | ac03629b1612ad008ea6603a3d142e291e3de9bb (patch) | |
| tree | aa201fda629b905dca4ca2efac65f3a16b8dbb32 /lib/test_fortify/write_overflow-strncpy-src.c | |
| parent | e0011bca603c101f2a3c007bdb77f7006fa78fb1 (diff) | |
Revert "nfsd: fix oops when reading pool_stats before server is started"
This reverts commit 8e948c365d9c10b685d1deb946bd833d6a9b43e0.
The reverted commit moves a test on a field protected by a mutex outside
of the protection of that mutex, and so is obviously racey.
Depending on how the race goes, si->serv might be NULL when dereferenced
in svc_pool_stats_start(), or svc_pool_stats_stop() might unlock a mutex
that hadn't been locked.
This bug that the commit tried to fix has been addressed by initialising
->mutex earlier.
Fixes: 8e948c365d9c ("nfsd: fix oops when reading pool_stats before server is started")
Signed-off-by: NeilBrown <[email protected]>
Reviewed-by: Jeff Layton <[email protected]>
Signed-off-by: Chuck Lever <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strncpy-src.c')
0 files changed, 0 insertions, 0 deletions