diff options
| author | Yu Kuai <[email protected]> | 2023-07-08 17:17:27 +0800 |
|---|---|---|
| committer | Song Liu <[email protected]> | 2023-08-15 09:37:27 -0700 |
| commit | a705b11b358dee677aad80630e7608b2d5f56691 (patch) | |
| tree | f9beddaeaf22c8aad64f734715b0c6a28d84464b /lib/test_fortify/write_overflow-strncpy-src.c | |
| parent | 66a6a5d0ec852eaced589da066376e69397cd71e (diff) | |
md/raid5-cache: fix a deadlock in r5l_exit_log()
Commit b13015af94cf ("md/raid5-cache: Clear conf->log after finishing
work") introduce a new problem:
// caller hold reconfig_mutex
r5l_exit_log
flush_work(&log->disable_writeback_work)
r5c_disable_writeback_async
wait_event
/*
* conf->log is not NULL, and mddev_trylock()
* will fail, wait_event() can never pass.
*/
conf->log = NULL
Fix this problem by setting 'config->log' to NULL before wake_up() as it
used to be, so that wait_event() from r5c_disable_writeback_async() can
exist. In the meantime, move forward md_unregister_thread() so that
null-ptr-deref this commit fixed can still be fixed.
Fixes: b13015af94cf ("md/raid5-cache: Clear conf->log after finishing work")
Signed-off-by: Yu Kuai <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Song Liu <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strncpy-src.c')
0 files changed, 0 insertions, 0 deletions