diff options
| author | Azeem Shaikh <[email protected]> | 2023-05-16 01:33:45 +0000 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2023-05-16 21:38:36 -0400 |
| commit | 973464fded698881d48c6439f9d9912d61819bd1 (patch) | |
| tree | ddf42096f640438eb85a83c484e3f1f0fa1331a5 /lib/test_fortify/write_overflow-strlcpy-src.c | |
| parent | 8759924ddb93498bd5777f0b05b6bc9cacf4ffe3 (diff) | |
scsi: bfa: Replace all non-returning strlcpy() with strscpy()
strlcpy() reads the entire source buffer first. This read may exceed the
destination size limit. This is both inefficient and can lead to linear
read overflows if a source string is not NUL-terminated [1]. In an effort
to remove strlcpy() completely [2], replace strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.
[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89
Signed-off-by: Azeem Shaikh <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Kees Cook <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strlcpy-src.c')
0 files changed, 0 insertions, 0 deletions