diff options
author | Kevin Mitchell <[email protected]> | 2022-05-17 11:01:05 -0700 |
---|---|---|
committer | David S. Miller <[email protected]> | 2022-05-18 14:00:51 +0100 |
commit | 942d2ad5d2e0df758a645ddfadffde2795322728 (patch) | |
tree | 8756518dee9f8bf1479973a589738d84d2056aac /lib/test_fortify/write_overflow-strlcpy-src.c | |
parent | b8cedb7093b2d1394cae9b86494cba4b62d3a30a (diff) |
igb: skip phy status check where unavailable
igb_read_phy_reg() will silently return, leaving phy_data untouched, if
hw->ops.read_reg isn't set. Depending on the uninitialized value of
phy_data, this led to the phy status check either succeeding immediately
or looping continuously for 2 seconds before emitting a noisy err-level
timeout. This message went out to the console even though there was no
actual problem.
Instead, first check if there is read_reg function pointer. If not,
proceed without trying to check the phy status register.
Fixes: b72f3f72005d ("igb: When GbE link up, wait for Remote receiver status condition")
Signed-off-by: Kevin Mitchell <[email protected]>
Tested-by: Gurucharan <[email protected]> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strlcpy-src.c')
0 files changed, 0 insertions, 0 deletions