diff options
author | Tejun Heo <[email protected]> | 2022-04-27 09:49:12 -1000 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2022-04-27 13:51:28 -0600 |
commit | 4cddeacad6d4b23493a108d0705e7d2ab89ba5a3 (patch) | |
tree | 4cd48b87f9ee474a66de078d79d2bc1bc5625443 /lib/test_fortify/write_overflow-strlcpy-src.c | |
parent | 8c936f9ea11ec4e35e288810a7503b5c841a355f (diff) |
Revert "block: inherit request start time from bio for BLK_CGROUP"
This reverts commit 0006707723233cb2a9a23ca19fc3d0864835704c. It has a
couple problems:
* bio_issue_time() is stored in bio->bi_issue truncated to 51 bits. This
overflows in slightly over 26 days. Setting rq->io_start_time_ns with it
means that io duration calculation would yield >26days after 26 days of
uptime. This, for example, confuses kyber making it cause high IO
latencies.
* rq->io_start_time_ns should record the time that the IO is issued to the
device so that on-device latency can be measured. However,
bio_issue_time() is set before the bio goes through the rq-qos controllers
(wbt, iolatency, iocost), so when the bio gets throttled in any of the
mechanisms, the measured latencies make no sense - on-device latencies end
up higher than request-alloc-to-completion latencies.
We'll need a smarter way to avoid calling ktime_get_ns() repeatedly
back-to-back. For now, let's revert the commit.
Signed-off-by: Tejun Heo <[email protected]>
Cc: [email protected] # v5.16+
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-strlcpy-src.c')
0 files changed, 0 insertions, 0 deletions