diff options
| author | NeilBrown <neilb@suse.de> | 2022-09-08 12:08:40 +1000 |
|---|---|---|
| committer | Chuck Lever <chuck.lever@oracle.com> | 2022-09-08 17:53:24 -0400 |
| commit | 00801cd92d91e94aa04d687f9bb9a9104e7c3d46 (patch) | |
| tree | 0d770e2196921ec19993da366fcb3309fb492c32 /lib/test_fortify/write_overflow-strcpy.c | |
| parent | 6930bcbfb6ceda63e298c6af6d733ecdf6bd4cde (diff) | |
NFSD: fix regression with setting ACLs.
A recent patch moved ACL setting into nfsd_setattr().
Unfortunately it didn't work as nfsd_setattr() aborts early if
iap->ia_valid is 0.
Remove this test, and instead avoid calling notify_change() when
ia_valid is 0.
This means that nfsd_setattr() will now *always* lock the inode.
Previously it didn't if only a ATTR_MODE change was requested on a
symlink (see Commit 15b7a1b86d66 ("[PATCH] knfsd: fix setattr-on-symlink
error return")). I don't think this change really matters.
Fixes: c0cbe70742f4 ("NFSD: add posix ACLs to struct nfsd_attrs")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Diffstat (limited to 'lib/test_fortify/write_overflow-strcpy.c')
0 files changed, 0 insertions, 0 deletions