diff options
| author | Baokun Li <[email protected]> | 2021-08-04 10:12:12 +0800 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2021-08-13 10:09:26 -0600 |
| commit | fad7cd3310db3099f95dd34312c77740fbc455e5 (patch) | |
| tree | 35e8edc8f8c4696ad38ab9ffeb07be76e4cfaf1a /lib/test_fortify/write_overflow-memcpy.c | |
| parent | da20b58d5bbbb0d23ae9530992a37d0f0d1787a4 (diff) | |
nbd: add the check to prevent overflow in __nbd_ioctl()
If user specify a large enough value of NBD blocks option, it may trigger
signed integer overflow which may lead to nbd->config->bytesize becomes a
large or small value, zero in particular.
UBSAN: Undefined behaviour in drivers/block/nbd.c:325:31
signed integer overflow:
1024 * 4611686155866341414 cannot be represented in type 'long long int'
[...]
Call trace:
[...]
handle_overflow+0x188/0x1dc lib/ubsan.c:192
__ubsan_handle_mul_overflow+0x34/0x44 lib/ubsan.c:213
nbd_size_set drivers/block/nbd.c:325 [inline]
__nbd_ioctl drivers/block/nbd.c:1342 [inline]
nbd_ioctl+0x998/0xa10 drivers/block/nbd.c:1395
__blkdev_driver_ioctl block/ioctl.c:311 [inline]
[...]
Although it is not a big deal, still silence the UBSAN by limit
the input value.
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Baokun Li <[email protected]>
Reviewed-by: Josef Bacik <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
[axboe: dropped unlikely()]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-memcpy.c')
0 files changed, 0 insertions, 0 deletions