diff options
| author | Nicolas Dufresne <[email protected]> | 2022-05-13 22:29:10 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2022-05-17 10:04:35 +0200 |
| commit | 9998943f6dfc5d5472bfab2e38527fb6ba5e9da7 (patch) | |
| tree | f7e9c8db448c4a0ad3604814386caef04a27a4ce /lib/test_fortify/write_overflow-memcpy.c | |
| parent | 1b729998633d6ad944d60c9bd9b1c48cd3bd9cf7 (diff) | |
media: rkvdec: Stop overclocking the decoder
While this overclock hack seems to work on some implementations
(some ChromeBooks, RockPi4) it also causes instability on other
implementations (notably LibreComputer Renegade, but there were more
reports in the LibreELEC project, where this has been removed). While
performance is indeed affected (tested with GStreamer), 4K playback
still works as long as you don't operate in lock step and keep at
least 1 frame ahead of time in the decode queue.
After discussion with ChromeOS members, it would seem that their
implementation indeed used to synchronously decode each frame, so
this hack was simply compensating for their code being less
efficient. In my opinion, this hack should not have been included
upstream.
Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")
Signed-off-by: Nicolas Dufresne <[email protected]>
Reviewed-by: Sebastian Fricke <[email protected]>
Reviewed-by: Ezequiel Garcia <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'lib/test_fortify/write_overflow-memcpy.c')
0 files changed, 0 insertions, 0 deletions