diff options
| author | Xiyu Yang <[email protected]> | 2020-04-15 16:31:50 +0800 |
|---|---|---|
| committer | Simon Wunderlich <[email protected]> | 2020-04-21 10:08:05 +0200 |
| commit | f872de8185acf1b48b954ba5bd8f9bc0a0d14016 (patch) | |
| tree | cab2eaa91a129bdfe0a5627259f9fb25f6203fc7 /lib/test-string_helpers.c | |
| parent | fd0c42c4dea54335967c5a86f15fc064235a2797 (diff) | |
batman-adv: Fix refcnt leak in batadv_show_throughput_override
batadv_show_throughput_override() invokes batadv_hardif_get_by_netdev(),
which gets a batadv_hard_iface object from net_dev with increased refcnt
and its reference is assigned to a local pointer 'hard_iface'.
When batadv_show_throughput_override() returns, "hard_iface" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The issue happens in the normal path of
batadv_show_throughput_override(), which forgets to decrease the refcnt
increased by batadv_hardif_get_by_netdev() before the function returns,
causing a refcnt leak.
Fix this issue by calling batadv_hardif_put() before the
batadv_show_throughput_override() returns in the normal path.
Fixes: 0b5ecc6811bd ("batman-adv: add throughput override attribute to hard_ifaces")
Signed-off-by: Xiyu Yang <[email protected]>
Signed-off-by: Xin Tan <[email protected]>
Signed-off-by: Sven Eckelmann <[email protected]>
Signed-off-by: Simon Wunderlich <[email protected]>
Diffstat (limited to 'lib/test-string_helpers.c')
0 files changed, 0 insertions, 0 deletions