diff options
author | Paul E. McKenney <[email protected]> | 2014-08-12 13:54:21 -0700 |
---|---|---|
committer | Paul E. McKenney <[email protected]> | 2014-09-16 10:08:03 -0700 |
commit | c847f14217d5aec5336272a54a32ffcf6e06ddcb (patch) | |
tree | 865d138fe6a772c37c4928518b257bb14834c793 /lib/test-string_helpers.c | |
parent | 1772947bd0126661866069157e95197e9c0020e9 (diff) |
rcu: Avoid misordering in nocb_leader_wait()
The NOCB follower wakeup ordering depends on the store to the tail
pointer happening before the wakeup. However, because atomic_long_add()
does not return a value, it does not provide ordering guarantees, and
the locking in wake_up() only guarantees that the store will happen
before the unlock, which might be too late. Even though this is only a
theoretical issue, this commit adds a smp_mb__after_atomic() after the
final atomic_long_add() to provide the needed ordering guarantee.
Reported-by: Amit Shah <[email protected]>
Signed-off-by: Paul E. McKenney <[email protected]>
Tested-by: Paul Gortmaker <[email protected]>
Diffstat (limited to 'lib/test-string_helpers.c')
0 files changed, 0 insertions, 0 deletions