diff options
| author | James Bottomley <[email protected]> | 2020-05-28 11:10:57 -0700 |
|---|---|---|
| committer | Jarkko Sakkinen <[email protected]> | 2020-07-02 17:48:59 +0300 |
| commit | 7862840219058436b80029a0263fd1ef065fb1b3 (patch) | |
| tree | 5862442d1f898b7c6ff9726670e4a5c135dfb7dc /lib/test-string_helpers.c | |
| parent | cd77006e01b3198c75fb7819b3d0ff89709539bb (diff) | |
tpm: Fix TIS locality timeout problems
It has been reported that some TIS based TPMs are giving unexpected
errors when using the O_NONBLOCK path of the TPM device. The problem
is that some TPMs don't like it when you get and then relinquish a
locality (as the tpm_try_get_ops()/tpm_put_ops() pair does) without
sending a command. This currently happens all the time in the
O_NONBLOCK write path. Fix this by moving the tpm_try_get_ops()
further down the code to after the O_NONBLOCK determination is made.
This is safe because the priv->buffer_mutex still protects the priv
state being modified.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206275
Fixes: d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
Reported-by: Mario Limonciello <[email protected]>
Tested-by: Alex Guzman <[email protected]>
Cc: [email protected]
Reviewed-by: Jerry Snitselaar <[email protected]>
Signed-off-by: James Bottomley <[email protected]>
Reviewed-by: Jarkko Sakkinen <[email protected]>
Signed-off-by: Jarkko Sakkinen <[email protected]>
Diffstat (limited to 'lib/test-string_helpers.c')
0 files changed, 0 insertions, 0 deletions