diff options
| author | Conor Dooley <conor.dooley@microchip.com> | 2023-04-13 23:20:45 +0100 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2023-04-13 15:44:11 -0700 |
| commit | 7455b7007b9e93bcc2bc9c1c6c73a228e3152069 (patch) | |
| tree | 45b1121d9ced8a597f4d5b79e391772d8ed7329f /lib/test-string_helpers.c | |
| parent | fb8b9d23f15f1440671d0127f7ad68d679fd29a3 (diff) | |
clk: microchip: fix potential UAF in auxdev release callback
Similar to commit 1c11289b34ab ("peci: cpu: Fix use-after-free in
adev_release()"), the auxiliary device is not torn down in the correct
order. If auxiliary_device_add() fails, the release callback will be
called twice, resulting in a UAF. Due to timing, the auxdev code in this
driver "took inspiration" from the aforementioned commit, and thus its
bugs too!
Moving auxiliary_device_uninit() to the unregister callback instead
avoids the issue.
CC: stable@vger.kernel.org
Fixes: b56bae2dd6fd ("clk: microchip: mpfs: add reset controller")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20230413-critter-synopsis-dac070a86cb4@spud
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'lib/test-string_helpers.c')
0 files changed, 0 insertions, 0 deletions