diff options
| author | Yu Kuai <[email protected]> | 2023-02-23 17:12:26 +0800 |
|---|---|---|
| committer | Jens Axboe <[email protected]> | 2023-03-15 09:25:04 -0600 |
| commit | 5f27571382ca42daa3e3d40d1b252bf18c2b61d2 (patch) | |
| tree | 8f1fe6b4727f5b014fb676ee07a9e233a2934ddf /lib/test-string_helpers.c | |
| parent | 6030363199e3a6341afb467ddddbed56640cbf6a (diff) | |
block: count 'ios' and 'sectors' when io is done for bio-based device
While using iostat for raid, I observed very strange 'await'
occasionally, and turns out it's due to that 'ios' and 'sectors' is
counted in bdev_start_io_acct(), while 'nsecs' is counted in
bdev_end_io_acct(). I'm not sure why they are ccounted like that
but I think this behaviour is obviously wrong because user will get
wrong disk stats.
Fix the problem by counting 'ios' and 'sectors' when io is done, like
what rq-based device does.
Fixes: 394ffa503bc4 ("blk: introduce generic io stat accounting help function")
Signed-off-by: Yu Kuai <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/test-string_helpers.c')
0 files changed, 0 insertions, 0 deletions