diff options
| author | David Woodhouse <[email protected]> | 2009-10-30 17:45:14 +0000 |
|---|---|---|
| committer | John W. Linville <[email protected]> | 2009-10-30 15:50:25 -0400 |
| commit | e9024a059f2c17fb2bfab212ee9d31511d7b8e57 (patch) | |
| tree | df915e4de67786102850f91e2b4deadf5fb10fe3 /lib/string_helpers.c | |
| parent | 372362ade2fe5c33d749e017f1c5bc8140769a3e (diff) | |
libertas if_usb: Fix crash on 64-bit machines
On a 64-bit kernel, skb->tail is an offset, not a pointer. The libertas
usb driver passes it to usb_fill_bulk_urb() anyway, causing interesting
crashes. Fix that by using skb->data instead.
This highlights a problem with usb_fill_bulk_urb(). It doesn't notice
when dma_map_single() fails and return the error to its caller as it
should. In fact it _can't_ currently return the error, since it returns
void.
So this problem was showing up only at unmap time, after we'd already
suffered memory corruption by doing DMA to a bogus address.
Signed-off-by: David Woodhouse <[email protected]>
Cc: [email protected]
Acked-by: David S. Miller <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions