diff options
author | john stultz <[email protected]> | 2010-12-16 19:03:27 +0000 |
---|---|---|
committer | Russell King <[email protected]> | 2010-12-22 22:44:43 +0000 |
commit | b5776c4a6d0afc13697e8452b9ebe1cc4d961b74 (patch) | |
tree | 0b60b679d636a9759849fea1cd36a33438fff5ef /lib/string_helpers.c | |
parent | 5e06b6492e53ab2a4e467763a9ee9f70b032c301 (diff) |
Fix rounding in clocks_calc_mult_shift()
Russell King reports:
| On the ARM dev boards, we have a 32-bit counter running at 24MHz. Calling
| clocks_calc_mult_shift(&mult, &shift, 24MHz, NSEC_PER_SEC, 60) gives
| us a multiplier of 2796202666 and a shift of 26.
|
| Over a large counter delta, this produces an error - lets take a count
| from 362976315 to 4280663372:
|
| (4280663372-362976315) * 2796202666 / 2^26 - (4280663372-362976315) * (1000/24)
| => -38.91872422891230269990
|
| Can we do better?
|
| (4280663372-362976315) * 2796202667 / 2^26 - (4280663372-362976315) * (1000/24)
| 19.45936211449532822051
|
| which is about twice as good as the 2796202666 multiplier.
|
| Looking at the equivalent divisions obtained, 2796202666 / 2^26 gives
| 41.66666665673255920410ns per tick, whereas 2796202667 / 2^26 gives
| 41.66666667163372039794ns. The actual value wanted is 1000/24 =
| 41.66666666666666666666ns.
Fix this by ensuring we round to nearest when calculating the
multiplier.
Signed-off-by: John Stultz <[email protected]>
Tested-by: Santosh Shilimkar <[email protected]>
Tested-by: Will Deacon <[email protected]>
Tested-by: Mikael Pettersson <[email protected]>
Tested-by: Eric Miao <[email protected]>
Tested-by: Olof Johansson <[email protected]>
Tested-by: Jamie Iles <[email protected]>
Signed-off-by: Russell King <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions