diff options
| author | Lachlan McIlroy <[email protected]> | 2008-10-30 16:53:25 +1100 |
|---|---|---|
| committer | Lachlan McIlroy <[email protected]> | 2008-11-10 17:43:23 +1100 |
| commit | 9ccbece546cf836f67f6d9bb4bf2f70f7476cb2c (patch) | |
| tree | 86b6b97537c46eb70555fbe8ffdc16e1ec8b69d0 /lib/string_helpers.c | |
| parent | 75fa67706cce5272bcfc51ed646f2da21f3bdb6e (diff) | |
[XFS] Fix use-after-free with log and quotas
Destroying the quota stuff on unmount can access the log - ie
XFS_QM_DONE() ends up in xfs_dqunlock() which calls
xfs_trans_unlocked_item() and then xfs_log_move_tail(). By this time the
log has already been destroyed. Just move the cleanup of the quota code
earlier in xfs_unmountfs() before the call to xfs_log_unmount(). Moving
XFS_QM_DONE() up near XFS_QM_DQPURGEALL() seems like a good spot.
SGI-PV: 987086
SGI-Modid: xfs-linux-melb:xfs-kern:32148a
Signed-off-by: Lachlan McIlroy <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Signed-off-by: Peter Leckie <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions