diff options
| author | Stefan Roese <[email protected]> | 2012-08-28 11:34:13 +0200 |
|---|---|---|
| committer | David Woodhouse <[email protected]> | 2012-09-29 15:29:08 +0100 |
| commit | 7be1f6b9a1ae3476a424380b52aad7c14c3273ab (patch) | |
| tree | 0d005f8a83ad814b37ec75e72784d658b9b95e85 /lib/string_helpers.c | |
| parent | a5ff4f102937a3492bca4a9ff0c341d78813414c (diff) | |
mtd: cfi_cmdset_0001: Fix problem with unlocking timeout
Unlocking may take up to 1.4 seconds on some Intel flashes. So
lets use a max. of 1.5 seconds (1500ms) as timeout.
See "Clear Block Lock-Bits Time" on page 40 in
"3 Volt Intel StrataFlash Memory" 28F128J3,28F640J3,28F320J3 manual
from February 2003
This patch also fixes some other problems with this timeout:
- Don't use HZ in timeout "calculation"!
While testing we noticed that an unlocking timeout occured with
HZ=1000 and didn't occur with HZ=300. This was because the
timeout parameter was calculated differently depending on the
HZ value. Now a fixed value of 1500ms is used.
- The last parameter of WAIT_TIMEOUT (defined to
inval_cache_and_wait_for_operation) has to be passed in
micro-seconds. So multiply the ms value with 1000 and not 100
to calculate this value.
- Use variable name "mdelay" instead of misleading "udelay".
Signed-off-by: Stefan Roese <[email protected]>
Tested-by: Stephan Gatzka <[email protected]>
Signed-off-by: Artem Bityutskiy <[email protected]>
Signed-off-by: David Woodhouse <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions