diff options
author | Shengjiu Wang <[email protected]> | 2022-09-21 09:58:43 +0800 |
---|---|---|
committer | Mathieu Poirier <[email protected]> | 2022-09-21 11:21:33 -0600 |
commit | 467233a4ac29b215d492843d067a9f091e6bf0c5 (patch) | |
tree | c5a0ac92621e80179e76b41350a7071f2d6f5fe1 /lib/string_helpers.c | |
parent | 06564be4c03ff0e0b88c5a4a14a6527fcb070ffd (diff) |
rpmsg: char: Avoid double destroy of default endpoint
The rpmsg_dev_remove() in rpmsg_core is the place for releasing
this default endpoint.
So need to avoid destroying the default endpoint in
rpmsg_chrdev_eptdev_destroy(), this should be the same as
rpmsg_eptdev_release(). Otherwise there will be double destroy
issue that ept->refcount report warning:
refcount_t: underflow; use-after-free.
Call trace:
refcount_warn_saturate+0xf8/0x150
virtio_rpmsg_destroy_ept+0xd4/0xec
rpmsg_dev_remove+0x60/0x70
The issue can be reproduced by stopping remoteproc before
closing the /dev/rpmsgX.
Fixes: bea9b79c2d10 ("rpmsg: char: Add possibility to use default endpoint of the rpmsg device")
Signed-off-by: Shengjiu Wang <[email protected]>
Reviewed-by: Arnaud Pouliquen <[email protected]>
Reviewed-by: Peng Fan <[email protected]>
Cc: stable <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mathieu Poirier <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions