diff options
author | Borislav Petkov <[email protected]> | 2018-04-21 10:19:30 +0200 |
---|---|---|
committer | Thomas Gleixner <[email protected]> | 2018-04-24 09:48:22 +0200 |
commit | 09e182d17e8891dd73baba961a0f5a82e9274c97 (patch) | |
tree | 731cf6211c5938540c74d3703cfd4fe320314db8 /lib/string_helpers.c | |
parent | 84749d83758af6576552046b215b9b7f37f9556b (diff) |
x86/microcode: Do not exit early from __reload_late()
Vitezslav reported a case where the
"Timeout during microcode update!"
panic would hit. After a deeper look, it turned out that his .config had
CONFIG_HOTPLUG_CPU disabled which practically made save_mc_for_early() a
no-op.
When that happened, the discovered microcode patch wasn't saved into the
cache and the late loading path wouldn't find any.
This, then, lead to early exit from __reload_late() and thus CPUs waiting
until the timeout is reached, leading to the panic.
In hindsight, that function should have been written so it does not return
before the post-synchronization. Oh well, I know better now...
Fixes: bb8c13d61a62 ("x86/microcode: Fix CPU synchronization routine")
Reported-by: Vitezslav Samel <[email protected]>
Signed-off-by: Borislav Petkov <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Vitezslav Samel <[email protected]>
Tested-by: Ashok Raj <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions