aboutsummaryrefslogtreecommitdiff
path: root/lib/string_helpers.c
diff options
context:
space:
mode:
authorXiaoke Wang <[email protected]>2022-09-09 19:45:57 +0800
committerGreg Kroah-Hartman <[email protected]>2022-09-24 13:07:44 +0200
commit06bfdb6d889f57fe9ce7bd139ce278b68f3a59de (patch)
treefda6072a399b8fc2389e0c196bf153c4bcb19475 /lib/string_helpers.c
parentb77599043f00fce9253d0f22522c5d5b521555ce (diff)
staging: r8188eu: fix a potential memory leak in rtw_init_cmd_priv()
In rtw_init_cmd_priv(), if `pcmdpriv->rsp_allocated_buf` is allocated in failure, then `pcmdpriv->cmd_allocated_buf` will not be properly released. Besides, considering there are only two error paths and the first one can directly return, we do not need to implicitly jump to the `exit` tag to execute the error handling code. So this patch added `kfree(pcmdpriv->cmd_allocated_buf);` on the error path to release the resource and simplified the return logic of rtw_init_cmd_priv(). As there is no proper device to test with, no runtime testing was performed. Tested-by: Philipp Hortmann <[email protected]> # Edimax N150 Signed-off-by: Xiaoke Wang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
Diffstat (limited to 'lib/string_helpers.c')
0 files changed, 0 insertions, 0 deletions