diff options
author | Eric Dumazet <[email protected]> | 2024-05-15 16:33:58 +0000 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2024-05-16 19:38:05 -0700 |
commit | 581073f626e387d3e7eed55c48c8495584ead7ba (patch) | |
tree | 4ef79fb695b5a7965710ba045979db1ae9cc4158 /lib/string.c | |
parent | fa033def4171d2e4e29d5e3714fb2a5b1fc077e8 (diff) |
af_packet: do not call packet_read_pending() from tpacket_destruct_skb()
trafgen performance considerably sank on hosts with many cores
after the blamed commit.
packet_read_pending() is very expensive, and calling it
in af_packet fast path defeats Daniel intent in commit
b013840810c2 ("packet: use percpu mmap tx frame pending refcount")
tpacket_destruct_skb() makes room for one packet, we can immediately
wakeup a producer, no need to completely drain the tx ring.
Fixes: 89ed5b519004 ("af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET")
Signed-off-by: Eric Dumazet <[email protected]>
Cc: Neil Horman <[email protected]>
Cc: Daniel Borkmann <[email protected]>
Reviewed-by: Willem de Bruijn <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions