diff options
| author | Petr Machata <[email protected]> | 2019-07-02 19:06:47 +0000 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2019-07-02 15:31:20 -0700 |
| commit | dbcdb61aaf1add3fb15f24f7fcbf30c17d5c11db (patch) | |
| tree | 2e58130f3ed86d3847890a1421ee6ff053cb9760 /lib/pm-notifier-error-inject.c | |
| parent | c782e204f7343b6f4527e953a5ad265be4abd627 (diff) | |
mlxsw: spectrum_ptp: Fix validation in mlxsw_sp1_ptp_packet_finish()
Before mlxsw_sp1_ptp_packet_finish() sends the packet back, it validates
whether the corresponding port is still valid. However the condition is
incorrect: when mlxsw_sp_port == NULL, the code dereferences the port to
compare it to skb->dev.
The condition needs to check whether the port is present and skb->dev still
refers to that port (or else is NULL). If that does not hold, bail out.
Add a pair of parentheses to fix the condition.
Fixes: d92e4e6e33c8 ("mlxsw: spectrum: PTP: Support timestamping on Spectrum-1")
Reported-by: Colin Ian King <[email protected]>
Signed-off-by: Petr Machata <[email protected]>
Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Ido Schimmel <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/pm-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions