diff options
author | Jakub Kicinski <[email protected]> | 2022-06-29 11:19:10 -0700 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2022-06-30 11:34:10 -0700 |
commit | ff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5 (patch) | |
tree | 257bdc6083b6cb0de9b9fb20c4cea6dc724fb60a /lib/netdev-notifier-error-inject.c | |
parent | 9c5de246c1dbe785268fc2e83c88624b92e4ec93 (diff) |
net: tun: avoid disabling NAPI twice
Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.
Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.
Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <[email protected]>
Reported-by: Eric Dumazet <[email protected]>
Reviewed-by: Eric Dumazet <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions