diff options
author | Arnd Bergmann <[email protected]> | 2023-06-28 11:49:18 +0200 |
---|---|---|
committer | Kees Cook <[email protected]> | 2023-07-13 09:54:32 -0700 |
commit | ec7633de404e7ce704d8f79081b97bca5b616c23 (patch) | |
tree | b58cf80ca2018004682bd14a1ec9e06b60804876 /lib/netdev-notifier-error-inject.c | |
parent | e0b7b2081233ac7fe55838ff68cbc7ca9887a91f (diff) |
sparc: mark __arch_xchg() as __always_inline
An otherwise correct change to the atomic operations uncovered an
existing bug in the sparc __arch_xchg() function, which is calls
__xchg_called_with_bad_pointer() when its arguments are unknown at
compile time:
ERROR: modpost: "__xchg_called_with_bad_pointer" [lib/atomic64_test.ko] undefined!
This now happens because gcc determines that it's better to not inline the
function. Avoid this by just marking the function as __always_inline
to force the compiler to do the right thing here.
Reported-by: Guenter Roeck <[email protected]>
Link: https://lore.kernel.org/all/[email protected]/
Fixes: d12157efc8e08 ("locking/atomic: make atomic*_{cmp,}xchg optional")
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>
Acked-by: Mark Rutland <[email protected]>
Reviewed-by: Sam Ravnborg <[email protected]>
Acked-by: Guenter Roeck <[email protected]>
Acked-by: Andi Shyti <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Kees Cook <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions