diff options
| author | Parav Pandit <[email protected]> | 2019-05-10 10:26:23 -0500 |
|---|---|---|
| committer | Saeed Mahameed <[email protected]> | 2019-05-28 18:25:41 -0700 |
| commit | 9414277a5df3669c67e818708c0f881597e0118e (patch) | |
| tree | 75e27f682502a9bb77f6181ac926714f93bada33 /lib/netdev-notifier-error-inject.c | |
| parent | 905f6bd30bb6c244f97cdf5fb5d55cf263844490 (diff) | |
net/mlx5: Avoid double free in fs init error unwinding path
In below code flow, for ingress acl table root ns memory leads
to double free.
mlx5_init_fs
init_ingress_acls_root_ns()
init_ingress_acl_root_ns
kfree(steering->esw_ingress_root_ns);
/* steering->esw_ingress_root_ns is not marked NULL */
mlx5_cleanup_fs
cleanup_ingress_acls_root_ns
steering->esw_ingress_root_ns non NULL check passes.
kfree(steering->esw_ingress_root_ns);
/* double free */
Similar issue exist for other tables.
Hence zero out the pointers to not process the table again.
Fixes: 9b93ab981e3bf ("net/mlx5: Separate ingress/egress namespaces for each vport")
Fixes: 40c3eebb49e51 ("net/mlx5: Add support in RDMA RX steering")
Signed-off-by: Parav Pandit <[email protected]>
Reviewed-by: Mark Bloch <[email protected]>
Signed-off-by: Saeed Mahameed <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions