diff options
| author | Eric Dumazet <[email protected]> | 2015-11-02 09:03:11 -0800 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2015-11-02 22:47:14 -0500 |
| commit | 1d6119baf0610f813eb9d9580eb4fd16de5b4ceb (patch) | |
| tree | 0ea51e8f1fc3135c901acce5f49469b5e37f61b9 /lib/netdev-notifier-error-inject.c | |
| parent | c451113291c193d3bfbd0682011d2979d649010c (diff) | |
net: fix percpu memory leaks
This patch fixes following problems :
1) percpu_counter_init() can return an error, therefore
init_frag_mem_limit() must propagate this error so that
inet_frags_init_net() can do the same up to its callers.
2) If ip[46]_frags_ns_ctl_register() fail, we must unwind
properly and free the percpu_counter.
Without this fix, we leave freed object in percpu_counters
global list (if CONFIG_HOTPLUG_CPU) leading to crashes.
This bug was detected by KASAN and syzkaller tool
(http://github.com/google/syzkaller)
Fixes: 6d7b857d541e ("net: use lib/percpu_counter API for fragmentation mem accounting")
Signed-off-by: Eric Dumazet <[email protected]>
Reported-by: Dmitry Vyukov <[email protected]>
Cc: Hannes Frederic Sowa <[email protected]>
Cc: Jesper Dangaard Brouer <[email protected]>
Acked-by: Hannes Frederic Sowa <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/netdev-notifier-error-inject.c')
0 files changed, 0 insertions, 0 deletions