diff options
author | Linus Walleij <[email protected]> | 2022-07-22 13:46:11 +0200 |
---|---|---|
committer | Arnd Bergmann <[email protected]> | 2022-07-22 15:03:08 +0200 |
commit | c5cdb9286913aa5a5ebb81bcca0c17df3b0e2c79 (patch) | |
tree | 0858c137b655f7725f33e35a3b44190bad76c64d /lib/mpi | |
parent | 430d31bb2e6031f82fe2f2fe15500dde2ac5f8a6 (diff) |
ARM: pxa2xx: Fix GPIO descriptor tables
Laurence reports:
"Kernel >5.18 on Zaurus has a bug where the power management code can't
talk to devices, emitting the following errors:
sharpsl-pm sharpsl-pm: Error: AC check failed: voltage -22.
sharpsl-pm sharpsl-pm: Charging Error!
sharpsl-pm sharpsl-pm: Warning: Cannot read main battery!
Looking at the recent changes, I found that commit 31455bbda208 ("spi:
pxa2xx_spi: Convert to use GPIO descriptors") replaced the deprecated
SPI chip select platform device code with a gpiod lookup table. However,
this didn't seem to work until I changed the `dev_id` member from the
device name to the bus id. I'm not entirely sure why this is necessary,
but I suspect it is related to the fact that in sysfs SPI devices are
attached under /sys/devices/.../dev_name/spi_master/spiB/spiB.C, rather
than directly to the device."
After reviewing the change I conclude that the same fix is needed
for all affected boards.
Fixes: 31455bbda208 ("spi: pxa2xx_spi: Convert to use GPIO descriptors")
Reported-by: Laurence de Bruxelles <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/r/[email protected]'
Signed-off-by: Arnd Bergmann <[email protected]>
Diffstat (limited to 'lib/mpi')
0 files changed, 0 insertions, 0 deletions