diff options
author | David Howells <[email protected]> | 2013-03-13 14:59:45 -0700 |
---|---|---|
committer | Linus Torvalds <[email protected]> | 2013-03-13 15:21:48 -0700 |
commit | 51b154ed5289682364b830858a4a1ca47fcd04e7 (patch) | |
tree | a7e3ae9ad1047db6cedd5701df4b2f33f6386cd1 /lib/mpi | |
parent | 97da55fcec6e3898f50010a6847dfa64f7c085e6 (diff) |
UAPI: fix endianness conditionals in linux/aio_abi.h
In the UAPI header files, __BIG_ENDIAN and __LITTLE_ENDIAN must be
compared against __BYTE_ORDER in preprocessor conditionals where these are
exposed to userspace (that is they're not inside __KERNEL__ conditionals).
However, in the main kernel the norm is to check for
"defined(__XXX_ENDIAN)" rather than comparing against __BYTE_ORDER and
this has incorrectly leaked into the userspace headers.
The definition of PADDED() in linux/aio_abi.h is wrong in this way. Note
that userspace will likely interpret this and thus the order of fields in
struct iocb incorrectly as the little-endian variant on big-endian
machines - depending on header inclusion order.
[!!!] NOTE [!!!] This patch may adversely change the userspace API. It might
be better to fix the ordering of aio_key and aio_reserved1 in struct iocb.
Signed-off-by: David Howells <[email protected]>
Acked-by: Benjamin LaHaise <[email protected]>
Acked-by: Jeff Moyer <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'lib/mpi')
0 files changed, 0 insertions, 0 deletions