diff options
author | Stephen Boyd <[email protected]> | 2016-04-17 05:21:42 -0700 |
---|---|---|
committer | Dmitry Torokhov <[email protected]> | 2016-04-17 05:24:53 -0700 |
commit | eda5ecc0a6b865561997e177c393f0b0136fe3b7 (patch) | |
tree | 3d19c74c486fe015b0ebbbf6bdb6dc674ef84c0b /lib/mpi/mpiutil.c | |
parent | ca3704c23a3b3dfc9d721cf21953fd6b3cbfc3e0 (diff) |
Input: pmic8xxx-pwrkey - fix algorithm for converting trigger delay
The trigger delay algorithm that converts from microseconds to
the register value looks incorrect. According to most of the PMIC
documentation, the equation is
delay (Seconds) = (1 / 1024) * 2 ^ (x + 4)
except for one case where the documentation looks to have a
formatting issue and the equation looks like
delay (Seconds) = (1 / 1024) * 2 x + 4
Most likely this driver was written with the improper
documentation to begin with. According to the downstream sources
the valid delays are from 2 seconds to 1/64 second, and the
latter equation just doesn't make sense for that. Let's fix the
algorithm and the range check to match the documentation and the
downstream sources.
Reported-by: Bjorn Andersson <[email protected]>
Fixes: 92d57a73e410 ("input: Add support for Qualcomm PMIC8XXX power key")
Signed-off-by: Stephen Boyd <[email protected]>
Tested-by: John Stultz <[email protected]>
Acked-by: Bjorn Andersson <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions