aboutsummaryrefslogtreecommitdiff
path: root/lib/mpi/mpiutil.c
diff options
context:
space:
mode:
authorMing Lei <[email protected]>2022-12-15 10:16:29 +0800
committerJens Axboe <[email protected]>2022-12-15 05:23:11 -0700
commitd36a9ea5e7766961e753ee38d4c331bbe6ef659b (patch)
tree22838399e583bfba01ccc9a22ff67791f81d40e8 /lib/mpi/mpiutil.c
parent1eb206208b0f3f707c67134ef6ba394410effb67 (diff)
block: fix use-after-free of q->q_usage_counter
For blk-mq, queue release handler is usually called after blk_mq_freeze_queue_wait() returns. However, the q_usage_counter->release() handler may not be run yet at that time, so this can cause a use-after-free. Fix the issue by moving percpu_ref_exit() into blk_free_queue_rcu(). Since ->release() is called with rcu read lock held, it is agreed that the race should be covered in caller per discussion from the two links. Reported-by: Zhang Wensheng <[email protected]> Reported-by: Zhong Jinghua <[email protected]> Link: https://lore.kernel.org/linux-block/Y5prfOjyyjQKUrtH@T590/T/#u Link: https://lore.kernel.org/lkml/Y4%2FmzMd4evRg9yDi@fedora/ Cc: Hillf Danton <[email protected]> Cc: Yu Kuai <[email protected]> Cc: Dennis Zhou <[email protected]> Fixes: 2b0d3d3e4fcf ("percpu_ref: reduce memory footprint of percpu_ref in fast path") Signed-off-by: Ming Lei <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions