diff options
author | Jason A. Donenfeld <[email protected]> | 2022-04-08 18:14:57 +0200 |
---|---|---|
committer | Jason A. Donenfeld <[email protected]> | 2022-04-13 13:58:57 +0200 |
commit | b0c3e796f24b588b862b61ce235d3c9417dc8983 (patch) | |
tree | 7d583242af33f434736d0f26bf5003489b4a050b /lib/mpi/mpiutil.c | |
parent | 5209aed5137880fa229746cb521f715e55596460 (diff) |
random: make random_get_entropy() return an unsigned long
Some implementations were returning type `unsigned long`, while others
that fell back to get_cycles() were implicitly returning a `cycles_t` or
an untyped constant int literal. That makes for weird and confusing
code, and basically all code in the kernel already handled it like it
was an `unsigned long`. I recently tried to handle it as the largest
type it could be, a `cycles_t`, but doing so doesn't really help with
much.
Instead let's just make random_get_entropy() return an unsigned long all
the time. This also matches the commonly used `arch_get_random_long()`
function, so now RDRAND and RDTSC return the same sized integer, which
means one can fallback to the other more gracefully.
Cc: Dominik Brodowski <[email protected]>
Cc: Theodore Ts'o <[email protected]>
Acked-by: Thomas Gleixner <[email protected]>
Signed-off-by: Jason A. Donenfeld <[email protected]>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions