diff options
author | Alex Williamson <alex.williamson@redhat.com> | 2022-08-29 21:05:40 -0600 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2022-08-31 08:57:30 -0600 |
commit | 873aefb376bbc0ed1dd2381ea1d6ec88106fdbd4 (patch) | |
tree | ed1101504531fdfc35557bcf5c79a4b0bb165796 /lib/mpi/mpiutil.c | |
parent | b90cb1053190353cc30f0fef0ef1f378ccc063c5 (diff) |
vfio/type1: Unpin zero pages
There's currently a reference count leak on the zero page. We increment
the reference via pin_user_pages_remote(), but the page is later handled
as an invalid/reserved page, therefore it's not accounted against the
user and not unpinned by our put_pfn().
Introducing special zero page handling in put_pfn() would resolve the
leak, but without accounting of the zero page, a single user could
still create enough mappings to generate a reference count overflow.
The zero page is always resident, so for our purposes there's no reason
to keep it pinned. Therefore, add a loop to walk pages returned from
pin_user_pages_remote() and unpin any zero pages.
Cc: stable@vger.kernel.org
Reported-by: Luboslav Pivarc <lpivarc@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/166182871735.3518559.8884121293045337358.stgit@omen
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions