diff options
author | Paolo Bonzini <[email protected]> | 2014-11-07 23:04:00 +0100 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2014-11-11 11:04:49 -0700 |
commit | 2a90d4aae5509e9cf1ba848c5d0b3458201160a0 (patch) | |
tree | f327e5db3649df99d7f957ff6932eb7e7b5fc4ed /lib/mpi/mpiutil.c | |
parent | 398205b8391b208f0034a392242867b28ad8af3d (diff) |
blk-mq: use get_cpu/put_cpu instead of preempt_disable/preempt_enable
blk-mq is using preempt_disable/enable in order to ensure that the
queue runners are placed on the right CPU. This does not work with
the RT patches, because __blk_mq_run_hw_queue takes a non-raw
spinlock with the preemption-disabled region. If there is contention
on the lock, this violates the rules for preemption-disabled regions.
While this should be easily fixable within the RT patches just by doing
migrate_disable/enable, we can do better and document _why_ this
particular region runs with disabled preemption. After the previous
patch, it is trivial to switch it to get/put_cpu; the RT patches then
can change it to get_cpu_light, which lets virtio-blk run under RT
kernels.
Cc: Jens Axboe <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Reported-by: Clark Williams <[email protected]>
Tested-by: Clark Williams <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions