diff options
author | Nathan Lynch <[email protected]> | 2022-11-18 09:07:41 -0600 |
---|---|---|
committer | Michael Ellerman <[email protected]> | 2022-12-07 22:22:22 +1100 |
commit | ed2213bfb192ab51f09f12e9b49b5d482c6493f3 (patch) | |
tree | 2974cedc87276e9010227961eeb8ee9c7effb838 /lib/mpi/mpi-sub-ui.c | |
parent | b10af504a2015d12c566b6b0a4c7e3b602949eeb (diff) |
powerpc/rtas: avoid device tree lookups in rtas_os_term()
rtas_os_term() is called during panic. Its behavior depends on a couple
of conditions in the /rtas node of the device tree, the traversal of
which entails locking and local IRQ state changes. If the kernel panics
while devtree_lock is held, rtas_os_term() as currently written could
hang.
Instead of discovering the relevant characteristics at panic time,
cache them in file-static variables at boot. Note the lookup for
"ibm,extended-os-term" is converted to of_property_read_bool() since it
is a boolean property, not an RTAS function token.
Signed-off-by: Nathan Lynch <[email protected]>
Reviewed-by: Nicholas Piggin <[email protected]>
Reviewed-by: Andrew Donnellan <[email protected]>
[mpe: Incorporate suggested change from Nick]
Signed-off-by: Michael Ellerman <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions