diff options
| author | Sean Anderson <[email protected]> | 2022-10-20 11:50:41 -0400 |
|---|---|---|
| committer | David S. Miller <[email protected]> | 2022-10-24 10:45:14 +0100 |
| commit | c99f0f7e68376dda5df8db7950cd6b67e73c6d3c (patch) | |
| tree | 8b1c8f5f8e37e066d9044ebdca59a54008da214e /lib/mpi/mpi-sub-ui.c | |
| parent | f8127476930b98fc9e9aa5de0bbf9eeaf45db219 (diff) | |
net: fman: Use physical address for userspace interfaces
Before 262f2b782e25 ("net: fman: Map the base address once"), the
physical address of the MAC was exposed to userspace in two places: via
sysfs and via SIOCGIFMAP. While this is not best practice, it is an
external ABI which is in use by userspace software.
The aforementioned commit inadvertently modified these addresses and
made them virtual. This constitutes and ABI break. Additionally, it
leaks the kernel's memory layout to userspace. Partially revert that
commit, reintroducing the resource back into struct mac_device, while
keeping the intended changes (the rework of the address mapping).
Fixes: 262f2b782e25 ("net: fman: Map the base address once")
Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Sean Anderson <[email protected]>
Acked-by: Madalin Bucur <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions