aboutsummaryrefslogtreecommitdiff
path: root/lib/mpi/mpi-sub-ui.c
diff options
context:
space:
mode:
authorXiaomeng Tong <[email protected]>2022-03-27 16:10:02 +0800
committerMark Brown <[email protected]>2022-04-05 10:24:48 +0100
commitc8618d65007ba68d7891130642d73e89372101e8 (patch)
tree57597ed103d1eca0e2f0502a20c8555918ef8bc3 /lib/mpi/mpi-sub-ui.c
parentf730a46b931d894816af34a0ff8e4ad51565b39f (diff)
ASoC: rt5682: fix an incorrect NULL check on list iterator
The bug is here: if (!dai) { The list iterator value 'dai' will *always* be set and non-NULL by for_each_component_dais(), so it is incorrect to assume that the iterator value will be NULL if the list is empty or no element is found (In fact, it will be a bogus pointer to an invalid struct object containing the HEAD). Otherwise it will bypass the check 'if (!dai) {' (never call dev_err() and never return -ENODEV;) and lead to invalid memory access lately when calling 'rt5682_set_bclk1_ratio(dai, factor);'. To fix the bug, just return rt5682_set_bclk1_ratio(dai, factor); when found the 'dai', otherwise dev_err() and return -ENODEV; Cc: [email protected] Fixes: ebbfabc16d23d ("ASoC: rt5682: Add CCF usage for providing I2S clks") Signed-off-by: Xiaomeng Tong <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions