diff options
author | John Stultz <[email protected]> | 2020-06-13 04:21:59 +0000 |
---|---|---|
committer | Rob Clark <[email protected]> | 2020-06-12 21:59:11 -0700 |
commit | bc8bd54ffd8513e05eb87b5badcb2d586ea278f0 (patch) | |
tree | f49024bd97baeb129ea2fd557aa873a4a7ce2778 /lib/mpi/mpi-sub-ui.c | |
parent | 2e7ec6b5297157efabb50e5f82adc628cf90296c (diff) |
drm/msm: Fix 0xfffflub in "Refactor address space initialization"
This week I started seeing GPU crashes on my DragonBoard 845c
which I narrowed down to being caused by commit ccac7ce373c1
("drm/msm: Refactor address space initialization").
Looking through the patch, Jordan and I couldn't find anything
obviously wrong, so I ended up breaking that change up into a
number of smaller logical steps so I could figure out which part
was causing the trouble.
Ends up, visually counting 'f's is hard, esp across a number
of lines:
0xfffffff != 0xffffffff
This patch corrects the end value we pass in to
msm_gem_address_space_create() in
adreno_iommu_create_address_space() so that it matches the value
used before the problematic patch landed.
With this change, I no longer see the GPU crashes that were
affecting me.
Cc: Shawn Guo <[email protected]>
Cc: Rob Clark <[email protected]>
Cc: Sean Paul <[email protected]>
Cc: Jordan Crouse <[email protected]>
Cc: [email protected]
Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization")
Signed-off-by: John Stultz <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions